Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[26.1 backport] Fix hang when container fails to start #5062

Merged
merged 2 commits into from
May 7, 2024

Conversation

laurazard
Copy link
Member

@laurazard laurazard commented May 7, 2024

- Description for the changelog

Fix issue where the CLI process would sometimes hang when a container failed to start.

Signed-off-by: Laura Brehm <laurabrehm@hey.com>
(cherry picked from commit 31644d5)
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
(cherry picked from commit 8d6e571)
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
@laurazard laurazard self-assigned this May 7, 2024
@laurazard laurazard added the kind/bugfix PR's that fix bugs label May 7, 2024
@vvoland vvoland merged commit 53a3f0b into docker:26.1 May 7, 2024
92 checks passed
@thaJeztah thaJeztah added this to the 26.1.2 milestone May 7, 2024
renovate bot added a commit to earthly/dind that referenced this pull request May 9, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [docker/docker](https://togithub.com/docker/docker) | patch | `26.1.1`
-> `26.1.2` |

---

### Release Notes

<details>
<summary>docker/docker (docker/docker)</summary>

### [`v26.1.2`](https://togithub.com/moby/moby/releases/tag/v26.1.2)

[Compare
Source](https://togithub.com/docker/docker/compare/v26.1.1...v26.1.2)

#### 26.1.2

For a full list of pull requests and changes in this release, refer to
the relevant GitHub milestones:

- [docker/cli, 26.1.2
milestone](https://togithub.com/docker/cli/issues?q=is%3Aclosed+milestone%3A26.1.2)
- [moby/moby, 26.1.2
milestone](https://togithub.com/moby/moby/issues?q=is%3Aclosed+milestone%3A26.1.2)
- Deprecated and removed features, see [Deprecated
Features](https://togithub.com/docker/cli/blob/v26.1.2/docs/deprecated.md).
- Changes to the Engine API, see [API version
history](https://togithub.com/moby/moby/blob/v26.1.2/docs/api/version-history.md).

##### Bug fixes and enhancements

- Fix issue where the CLI process would sometimes hang when a container
failed to start.
[docker/cli#5062](https://togithub.com/docker/cli/pull/5062)

##### Packaging updates

- Update Go runtime to 1.21.10.
[moby/moby#47806](https://togithub.com/moby/moby/pull/47806)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 6am on monday" (UTC), Automerge
- At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/earthly/dind).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZSJdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot added a commit to earthly/dind that referenced this pull request May 9, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [docker/docker](https://togithub.com/docker/docker) | patch | `26.1.1`
-> `26.1.2` |

---

### Release Notes

<details>
<summary>docker/docker (docker/docker)</summary>

### [`v26.1.2`](https://togithub.com/moby/moby/releases/tag/v26.1.2)

[Compare
Source](https://togithub.com/docker/docker/compare/v26.1.1...v26.1.2)

#### 26.1.2

For a full list of pull requests and changes in this release, refer to
the relevant GitHub milestones:

- [docker/cli, 26.1.2
milestone](https://togithub.com/docker/cli/issues?q=is%3Aclosed+milestone%3A26.1.2)
- [moby/moby, 26.1.2
milestone](https://togithub.com/moby/moby/issues?q=is%3Aclosed+milestone%3A26.1.2)
- Deprecated and removed features, see [Deprecated
Features](https://togithub.com/docker/cli/blob/v26.1.2/docs/deprecated.md).
- Changes to the Engine API, see [API version
history](https://togithub.com/moby/moby/blob/v26.1.2/docs/api/version-history.md).

##### Bug fixes and enhancements

- Fix issue where the CLI process would sometimes hang when a container
failed to start.
[docker/cli#5062](https://togithub.com/docker/cli/pull/5062)

##### Packaging updates

- Update Go runtime to 1.21.10.
[moby/moby#47806](https://togithub.com/moby/moby/pull/47806)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 6am on monday" (UTC), Automerge
- At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/earthly/dind).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZSJdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bugfix PR's that fix bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants