-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[26.1 backport] Fix hang when container fails to start #5062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvoland
approved these changes
May 7, 2024
renovate bot
added a commit
to earthly/dind
that referenced
this pull request
May 9, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/docker](https://togithub.com/docker/docker) | patch | `26.1.1` -> `26.1.2` | --- ### Release Notes <details> <summary>docker/docker (docker/docker)</summary> ### [`v26.1.2`](https://togithub.com/moby/moby/releases/tag/v26.1.2) [Compare Source](https://togithub.com/docker/docker/compare/v26.1.1...v26.1.2) #### 26.1.2 For a full list of pull requests and changes in this release, refer to the relevant GitHub milestones: - [docker/cli, 26.1.2 milestone](https://togithub.com/docker/cli/issues?q=is%3Aclosed+milestone%3A26.1.2) - [moby/moby, 26.1.2 milestone](https://togithub.com/moby/moby/issues?q=is%3Aclosed+milestone%3A26.1.2) - Deprecated and removed features, see [Deprecated Features](https://togithub.com/docker/cli/blob/v26.1.2/docs/deprecated.md). - Changes to the Engine API, see [API version history](https://togithub.com/moby/moby/blob/v26.1.2/docs/api/version-history.md). ##### Bug fixes and enhancements - Fix issue where the CLI process would sometimes hang when a container failed to start. [docker/cli#5062](https://togithub.com/docker/cli/pull/5062) ##### Packaging updates - Update Go runtime to 1.21.10. [moby/moby#47806](https://togithub.com/moby/moby/pull/47806) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6am on monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/earthly/dind). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to earthly/dind
that referenced
this pull request
May 9, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/docker](https://togithub.com/docker/docker) | patch | `26.1.1` -> `26.1.2` | --- ### Release Notes <details> <summary>docker/docker (docker/docker)</summary> ### [`v26.1.2`](https://togithub.com/moby/moby/releases/tag/v26.1.2) [Compare Source](https://togithub.com/docker/docker/compare/v26.1.1...v26.1.2) #### 26.1.2 For a full list of pull requests and changes in this release, refer to the relevant GitHub milestones: - [docker/cli, 26.1.2 milestone](https://togithub.com/docker/cli/issues?q=is%3Aclosed+milestone%3A26.1.2) - [moby/moby, 26.1.2 milestone](https://togithub.com/moby/moby/issues?q=is%3Aclosed+milestone%3A26.1.2) - Deprecated and removed features, see [Deprecated Features](https://togithub.com/docker/cli/blob/v26.1.2/docs/deprecated.md). - Changes to the Engine API, see [API version history](https://togithub.com/moby/moby/blob/v26.1.2/docs/api/version-history.md). ##### Bug fixes and enhancements - Fix issue where the CLI process would sometimes hang when a container failed to start. [docker/cli#5062](https://togithub.com/docker/cli/pull/5062) ##### Packaging updates - Update Go runtime to 1.21.10. [moby/moby#47806](https://togithub.com/moby/moby/pull/47806) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6am on monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/earthly/dind). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Description for the changelog