Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[25.0 backport] volume/update: require 1 argument/fix panic #5511

Conversation

austinvazquez
Copy link
Contributor

@austinvazquez austinvazquez commented Oct 7, 2024

- What I did

This command was declaring that it requires at least 1 argument, when it needs exactly 1 argument. This was causing the CLI to panic when the command was invoked with no argument:

docker volume update

(cherry picked from commit daea277)

- How I did it

git cherry-pick -xsS daea277ee839742be94e1f41d5c477f114a81273

Similar to #5426, this change updates the test as Docker 26.1 CLI does not have the UX improvements which have been added to master.

- How to verify it

docker volume update

- Description for the changelog

Fix issue where `docker volume update` command would cause the CLI to panic if no argument/volume was passed.

- A picture of a cute animal (not mandatory but encouraged)

@austinvazquez austinvazquez marked this pull request as draft October 7, 2024 16:47
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.90%. Comparing base (b26009a) to head (024b3c1).
Report is 7 commits behind head on 25.0.

Additional details and impacted files
@@            Coverage Diff             @@
##             25.0    #5511      +/-   ##
==========================================
+ Coverage   59.85%   59.90%   +0.04%     
==========================================
  Files         329      329              
  Lines       22066    22066              
==========================================
+ Hits        13208    13219      +11     
+ Misses       7933     7921      -12     
- Partials      925      926       +1     

This command was declaring that it requires at least 1 argument, when it
needs exactly 1 argument. This was causing the CLI to panic when the
command was invoked with no argument:

`docker volume update`

Signed-off-by: Laura Brehm <laurabrehm@hey.com>
(cherry picked from commit daea277)
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
@austinvazquez austinvazquez force-pushed the cherry-pick-daea277ee839742be94e1f41d5c477f114a81273-to-25.0 branch from 1d8f54a to 024b3c1 Compare October 8, 2024 04:57
@austinvazquez austinvazquez marked this pull request as ready for review October 8, 2024 04:58
@thaJeztah thaJeztah added this to the 25.0.7 milestone Oct 8, 2024
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 315009c into docker:25.0 Oct 8, 2024
101 checks passed
@austinvazquez austinvazquez deleted the cherry-pick-daea277ee839742be94e1f41d5c477f114a81273-to-25.0 branch October 8, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants