Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change link to desktop docs #5600

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

aevesdocker
Copy link
Contributor

@aevesdocker aevesdocker commented Nov 7, 2024

Changed a link that points to the Docker Desktop docs.

Signed-off-by: aevesdocker <allie.sadler@docker.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.63%. Comparing base (9c01d92) to head (1440f9f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5600   +/-   ##
=======================================
  Coverage   59.63%   59.63%           
=======================================
  Files         346      346           
  Lines       29208    29208           
=======================================
  Hits        17417    17417           
  Misses      10822    10822           
  Partials      969      969           

[Explore networking features](https://docs.docker.com/desktop/networking/#i-want-to-connect-from-a-container-to-a-service-on-the-host).
[Explore networking features](https://docs.docker.com/desktop/features/networking/#i-want-to-connect-from-a-container-to-a-service-on-the-host).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, waiting on docker/docs#21354 to be merged

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes because it's updated by the linked PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH! It's not merged yet 😅

Let's wait with merging until that one is in (I see redirects are added as well, so old one should still work, correct?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we should merge this first, because otherwise CI would be failing https://github.com/docker/docs/actions/runs/11702658384/job/32591295114?pr=21354#step:4:418

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH! CI doesn't allow for redirects? 😢

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit f9497b8 into docker:master Nov 7, 2024
104 checks passed
@thaJeztah thaJeztah added this to the 28.0.0 milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants