[27.x backport] update go:build tags to use go1.22, fix missing go:build tag #5622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thaJeztah
commented
Nov 15, 2024
thaJeztah
commented
- backport: update go:build tags to use go1.22 #5608
- relates to golangci-lint: set go version to prevent fallback to go1.17, and fix copyloopvar linting issues #5594
- backport: cli/command/container: fix missing go:build tag #5621
- relates to build(deps): bump github.com/docker/cli from 27.3.2-0.20241008150905-cb3048fbebb1+incompatible to 27.4.0-rc.1+incompatible compose#12297 (comment)
commit 4a7b04d configured golangci-lint to use go1.23 semantics, which enabled the copyloopvar linter. go1.22 now creates a copy of variables when assigned in a loop; make sure we don't have files that may downgrade semantics to go1.21 in case that also means disabling that feature; https://go.dev/ref/spec#Go_1.22 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 7c80e4f) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
make shell
make -C ./internal/gocompat/
GO111MODULE=on go test -v
# github.com/docker/cli/cli/command/container
../../cli/command/container/completion.go:37:28: implicit function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod)
../../cli/command/container/completion.go:82:25: implicit function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod)
../../cli/command/container/completion.go:92:27: implicit function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod)
FAIL gocompat [build failed]
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit d1d5353)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
status/2-code-review
kind/bugfix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 27.x #5622 +/- ##
=======================================
Coverage 58.55% 58.55%
=======================================
Files 346 346
Lines 29329 29329
=======================================
Hits 17173 17173
Misses 11178 11178
Partials 978 978 |
vvoland
approved these changes
Nov 15, 2024
Benehiko
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.