Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated "daemon" subcommand #689

Merged
merged 1 commit into from
Nov 23, 2017

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Nov 13, 2017

The docker daemon subcommand was only present for backward compatibility, but deprecated in v1.13 (moby/moby#26834), and scheduled for removal in v17.12

- Description for the changelog

* Remove deprecated `docker daemon` command [docker/cli#689](https://github.com/docker/cli/pull/689)

@codecov-io
Copy link

codecov-io commented Nov 13, 2017

Codecov Report

Merging #689 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #689      +/-   ##
==========================================
+ Coverage   50.49%   50.57%   +0.07%     
==========================================
  Files         216      215       -1     
  Lines       17723    17678      -45     
==========================================
- Hits         8950     8941       -9     
+ Misses       8324     8290      -34     
+ Partials      449      447       -2

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-tags daemon can also be removed from scripts/test/unit

@thaJeztah
Copy link
Member Author

Ah, yes, I started looking for that one; let me do that in this PR as well 👍

The `docker daemon` subcommand was only present for
backward compatibility, but deprecated in v1.13,
and scheduled for removal in v17.12

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the remove-daemon-subcommand branch from 4642fdf to c6a3199 Compare November 13, 2017 18:01
@thaJeztah
Copy link
Member Author

Updated: removed the -tags daemon from scripts/test/unit

@dnephin dnephin merged commit 227dfea into docker:master Nov 23, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.12.0 milestone Nov 23, 2017
@thaJeztah thaJeztah deleted the remove-daemon-subcommand branch November 23, 2017 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants