-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated "daemon" subcommand #689
Conversation
Codecov Report
@@ Coverage Diff @@
## master #689 +/- ##
==========================================
+ Coverage 50.49% 50.57% +0.07%
==========================================
Files 216 215 -1
Lines 17723 17678 -45
==========================================
- Hits 8950 8941 -9
+ Misses 8324 8290 -34
+ Partials 449 447 -2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-tags daemon
can also be removed from scripts/test/unit
Ah, yes, I started looking for that one; let me do that in this PR as well 👍 |
The `docker daemon` subcommand was only present for backward compatibility, but deprecated in v1.13, and scheduled for removal in v17.12 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
4642fdf
to
c6a3199
Compare
Updated: removed the |
The
docker daemon
subcommand was only present for backward compatibility, but deprecated in v1.13 (moby/moby#26834), and scheduled for removal in v17.12- Description for the changelog