-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Severe performance degradation of all commands with versions >=2.24.4 (incl. 2.25.0) #11437
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
FWIW I'm seeing the same behavior with v2.24.3-desktop.1 and v2.24.6 on an Apple M2 laptop
This is reproducible with a simple compose.yaml and any docker compose sub-command. The following
|
I went a step further in trying to figure this out because having
Hopefully this will help narrow down where the problem is. |
Hey @nocive @dave-shawley |
@glours I can confirm the correct version is being used:
|
This comment was marked as outdated.
This comment was marked as outdated.
I reverted back to my installed version since I was seeing the same behavior in v2.24.6
I upgraded to Docker Desktop v4.27.2 this morning which bumped compose to 2.24.5 and the behavior is unchanged.
|
@nocive you're on linux? No Docker Desktop for Linux installed? |
@glours yes, I'm on arch running docker & docker-buildx pkgs + docker compose installed from the releases of this repo 🐧 I gave your binary a run and... it became even slower than before :) |
@nocive strange 🤔 Can you also try this binary? |
@glours sorry for the radio silence, I was pulled away to other work related things :) Didn't have time to isolate this in a simpler project BUT... ...managed to narrow it down a bit further to the usage of
When this variable is not set the
Does this help paint a better picture? Otherwise I'll try to dig deeper and isolate it with an example project, once time permits. |
Possible related/duplicate: #11305 |
In the meantime I've also upgraded to docker 25.0.2 but that made no difference. |
More strace findings:
|
Issue persists on 2.24.7. |
Does running commands with |
|
One more debugging question/hint: do you still have an older (24.0.7) docker cli/server? Here's what works for me to run the latest docker cli (but this might avoid the potential issue I have in mind): Maybe it's not about compose - it could be ... but between compose 2.24.3 and .4 there are also changes about cli/server libraries it uses. |
When skipping docker compose completely the issue never occurs, which I assume is what you were trying to demonstrate?
|
The issue has been introduced by the change: compose-spec/compose-go#546 It can be reproduced with this compose.yaml file. Running
I created the custom 2.25.0 build without compose-spec/compose-go#546 in the following way:
|
I can confirm removing this check has a mass impact on performance. There's something wrong with |
Any chance to get this fix in master soonish? 🙏 😇 |
Fixed in 2.26.0 (although not documented in release notes). |
Yeah 🎉 |
Description
Starting with version 2.24.4 I observe a noticeable and severe performance degradation with all docker compose commands.
We have a pretty sizable project with over 100 containers, in case that helps paint a better picture.
Steps To Reproduce
A big project with all containers stopped (assuming that even matters).
For versions <= 2.24.3
$ time docker compose ps NAME IMAGE COMMAND SERVICE CREATED STATUS PORTS real 0m0.423s user 0m0.478s sys 0m0.134s
With version >= 2.24.4:
$ time docker compose ps NAME IMAGE COMMAND SERVICE CREATED STATUS PORTS real 0m8.815s user 0m13.045s sys 0m0.358s
The delay (~8s) is observed before any output is produced and regardless of which command is ran.
I cannot reproduce the slowness with a simple test project of a couple of containers.
Happy to provide more information that can help hunt this down.
Compose Version
Docker Environment
Anything else?
No response
The text was updated successfully, but these errors were encountered: