Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in fig.yml aren't reflected unless you remove the containers #2

Closed
bfirsh opened this issue Jan 2, 2014 · 3 comments
Closed

Comments

@bfirsh
Copy link

bfirsh commented Jan 2, 2014

Maybe we should automatically remove containers which don't have volumes attached?

bfirsh added a commit that referenced this issue Jan 2, 2014
This needs more thought. Ref #2
@bfirsh
Copy link
Author

bfirsh commented Jan 3, 2014

So this is a half solution: b245848

Then fig up would recreate the containers when starting to set their new config. The problem with this is that they'll have new names (e.g. example_db_2) so all your links break. We need to leave the existing one in place so we can create them with volumes_from.

Some possible solutions:

@bfirsh
Copy link
Author

bfirsh commented Jan 16, 2014

@aanand can we consider this fixed?

@aanand
Copy link

aanand commented Jan 16, 2014

Yes.

@aanand aanand closed this as completed Jan 16, 2014
dnephin referenced this issue in dnephin/compose Sep 23, 2014
mauricioabreu referenced this issue in mauricioabreu/fig Dec 5, 2014
Added tests for containers with external links
chernjie referenced this issue in chernjie/compose Mar 23, 2015
Added unit tests in build_extra_hosts + fix
yuval-k pushed a commit to yuval-k/compose that referenced this issue Apr 10, 2015
This needs more thought. Ref docker#2

Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants