[DNM] update buildx to v0.10.0-rc2 #10122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
commented
Dec 24, 2022
Comment on lines
+175
to
+185
| // needs this replace otherwise: | ||
| // github.com/docker/compose/v2/pkg/compose imports | ||
| // github.com/moby/buildkit/client imports | ||
| // go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc tested by | ||
| // go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc.test imports | ||
| // google.golang.org/grpc/interop imports | ||
| // golang.org/x/oauth2/google imports | ||
| // cloud.google.com/go/compute/metadata: ambiguous import: found package cloud.google.com/go/compute/metadata in multiple modules: | ||
| // cloud.google.com/go v0.75.0 (X:\dev\go\pkg\mod\cloud.google.com\go@v0.75.0\compute\metadata) | ||
| // cloud.google.com/go/compute/metadata v0.2.1 (X:\dev\go\pkg\mod\cloud.google.com\go\compute\metadata@v0.2.1) | ||
| golang.org/x/oauth2 => golang.org/x/oauth2 v0.0.0-20221014153046-6fdb5e3db783 |
There was a problem hiding this comment.
we might need to update otel deps on buildx repo
crazy-max
commented
Dec 24, 2022
Comment on lines
+14
to
+16
| github.com/docker/cli v23.0.0-beta.1+incompatible | ||
| github.com/docker/cli-docs-tool v0.5.0 | ||
| github.com/docker/docker v20.10.20+incompatible // replaced; see replace rule for actual version | ||
| github.com/docker/docker v23.0.0-beta.1+incompatible |
There was a problem hiding this comment.
cli and moby update should be done in a dedicated pr (cc @thaJeztah)
Codecov ReportBase: 73.89% // Head: 73.89% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## v2 #10122 +/- ##
=======================================
Coverage 73.89% 73.89%
=======================================
Files 2 2
Lines 272 272
=======================================
Hits 201 201
Misses 60 60
Partials 11 11 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Replace by #10247 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just testing latest rc with new builder pkg.
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did