Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce --ignore-buildable to ignore buildable images on pull #10134

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Jan 3, 2023

What I did
docker compose pull --ignore-buildable will only pull images which have no build section.

Related issue
closes #8805

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@ndeloof ndeloof requested review from a team, nicksieger, StefanScherer, ulyssessouza, glours, milas and laurazard and removed request for a team January 3, 2023 09:57
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 74.26% // Head: 73.89% // Decreases project coverage by -0.36% ⚠️

Coverage data is based on head (0939d15) compared to base (a224780).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10134      +/-   ##
==========================================
- Coverage   74.26%   73.89%   -0.37%     
==========================================
  Files           2        2              
  Lines         272      272              
==========================================
- Hits          202      201       -1     
- Misses         59       60       +1     
  Partials       11       11              
Impacted Files Coverage Δ
pkg/e2e/framework.go 72.15% <0.00%> (-0.40%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit 8b4ac37 into docker:v2 Jan 3, 2023
@ndeloof ndeloof deleted the ignore-buildable branch January 3, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker compose pull fails with non zero if it contains image that needs to be built
2 participants