Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce --remove-orphans in compose create command #10160

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Jan 10, 2023

What I did
introduce --remove-orphans in compose create command to align with compose up and make orphan warning suggestion relevant

Related issue
closes #9718

(not mandatory) A picture of a cute animal, if possible in relation to what you did

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof requested review from a team, nicksieger, StefanScherer, ulyssessouza, glours, milas and laurazard and removed request for a team January 10, 2023 14:36
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL We have --remove-orphans on up (& now create) and not just down 😵

@ndeloof ndeloof enabled auto-merge (rebase) January 11, 2023 06:16
@ndeloof ndeloof disabled auto-merge January 11, 2023 06:16
@ndeloof ndeloof merged commit cc912c6 into docker:v2 Jan 11, 2023
@ndeloof ndeloof deleted the remove-orphans branch December 20, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker-compose create suggests --remove-orphans, which doesn't work
2 participants