support dry-run for cp command #10235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
force-pushed
the
dry-run-cp-support
branch
from
2c11512 to
9dc6789
Compare
glours
requested review from
a team,
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
milas and
laurazard
and removed request for
a team
Codecov ReportBase: 72.79% // Head: 73.89% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v2 #10235 +/- ##
==========================================
+ Coverage 72.79% 73.89% +1.10%
==========================================
Files 2 2
Lines 272 272
==========================================
+ Hits 198 201 +3
+ Misses 62 60 -2
+ Partials 12 11 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ndeloof
approved these changes
Feb 3, 2023
ndeloof
reviewed
Feb 3, 2023
glours
force-pushed
the
dry-run-cp-support
branch
from
2b4ed0f to
280b04f
Compare
milas
approved these changes
Feb 3, 2023
| return nil, moby.ContainerPathStat{}, ErrNotImplemented | ||
| rc := io.NopCloser(strings.NewReader("")) | ||
| if _, err := d.ContainerStatPath(ctx, container, srcPath); err != nil { | ||
| return rc, moby.ContainerPathStat{}, fmt.Errorf(" %s Could not find the file %s in container %s", DRYRUN_PREFIX, srcPath, container) |
There was a problem hiding this comment.
I was going to suggest s/file/path but then realized this text comes from moby/moby 🙈
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
…oth way) Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
force-pushed
the
dry-run-cp-support
branch
from
280b04f to
fdc1738
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guillaume Lours 705411+glours@users.noreply.github.com
What I did
Add support of dry-run mode for
cpcommandRelated issue
https://docker.atlassian.net/browse/ENV-53
(not mandatory) A picture of a cute animal, if possible in relation to what you did
