use CGO to enable fsevent on OSX [ENV-37] #10249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 72.79% // Head: 73.89% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v2 #10249 +/- ##
==========================================
+ Coverage 72.79% 73.89% +1.10%
==========================================
Files 2 2
Lines 272 272
==========================================
+ Hits 198 201 +3
+ Misses 62 60 -2
+ Partials 12 11 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
nicksieger
reviewed
Feb 7, 2023
| RUN --mount=type=bind,target=. \ | ||
| --mount=type=cache,target=/root/.cache \ | ||
| --mount=type=cache,target=/go/pkg/mod \ | ||
| --mount=type=bind,from=osxcross,src=/osxsdk,target=/xx-sdk \ | ||
| xx-go --wrap && \ | ||
| if [ "$(xx-info os)" == "darwin" ]; then export CGO_ENABLED=1; fi && \ |
There was a problem hiding this comment.
Maybe default CGO_ENABLED to 0 on the other platforms? Not sure if it gets set elsewhere.
Suggested change
| if [ "$(xx-info os)" == "darwin" ]; then export CGO_ENABLED=1; fi && \ | |
| export CGO_ENABLED=0 && \ | |
| if [ "$(xx-info os)" == "darwin" ]; then CGO_ENABLED=1; fi && \ |
There was a problem hiding this comment.
it is set by default on https://github.com/docker/compose/blob/v2/Dockerfile#L91
ndeloof
force-pushed
the
CGO
branch
3 times, most recently
from
f3fca5a to
effb4e8
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
use CGO so we can rely on fsevent for
compose watchon MacOS(not mandatory) A picture of a cute animal, if possible in relation to what you did
![Uploading image.png…]()