don't use unitialized cli to setup DryRunClient #10770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10770 +/- ##
==========================================
- Coverage 59.14% 59.14% -0.01%
==========================================
Files 115 115
Lines 9850 9852 +2
==========================================
+ Hits 5826 5827 +1
- Misses 3433 3435 +2
+ Partials 591 590 -1
☔ View full report in Codecov by Sentry. |
milas
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
use the actual dockerCli to setup DryRunClient, otherwise we get a chicked/egg problem with buildx trying to guess the active context while we are still intializing
Related issue
fixes #10766
(not mandatory) A picture of a cute animal, if possible in relation to what you did
