-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add scale command #10979
add scale command #10979
Conversation
f14aa70
to
352d7b7
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #10979 +/- ##
==========================================
+ Coverage 57.72% 57.90% +0.17%
==========================================
Files 127 129 +2
Lines 11092 11160 +68
==========================================
+ Hits 6403 6462 +59
- Misses 4058 4060 +2
- Partials 631 638 +7
☔ View full report in Codecov by Sentry. |
f8a96fe
to
bbb93a7
Compare
|
53dda54
to
9054dab
Compare
9054dab
to
2c86e64
Compare
Noting that we should update docs after merging this: https://docs.docker.com/compose/migrate/#unsupported-in-v2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2c86e64
to
b0b1881
Compare
Ok my test assertions are fragiles as we can't bet which container will be removed 😬
I'll improve this tomorrow |
e1cc36a
to
b69cea4
Compare
I'm surprised your assertion failed...I thought we'd made scale deterministic at some point, so that it would always leave the "oldest" (lowest-numbered) replicas |
@milas I think the 2 replicas were created at the same time 🤷♂️ |
17056d0
to
2c51c69
Compare
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
Co-authored-by: Milas Bowman <devnull@milas.dev> Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
2c51c69
to
05a6da0
Compare
What I did
Add a
scale
commandRelated issue
https://docker.atlassian.net/browse/ENV-310
#10965
(not mandatory) A picture of a cute animal, if possible in relation to what you did