Fix for "Application failed to start after update" when an external network is on a watched service

[kimdcottrell]

What I did

I'll keep editing this part with progress. WIP

At present:

• e2e test that shows bug reported in issue
• fix for bug 🥳
• rebased commits so I could amend a signoff on work done

Remaining:

• duplicate code in e2e test should be refactored.
• anything that gets flagged by automated tests below

Related issue
Fixes: #11081

(not mandatory) A picture of a cute animal, if possible in relation to what you did
https://giphy.com/gifs/justviralnet-funny-dog-corgi-ZFFVNwIbjsKtP3lHYK

[kimdcottrell]

The test right now has some duplicate code from elsewhere in the same file. It's on my list of things to refactor for the next commit, though I wanted to get this out the door so people could give me advice if they so chose.

[codecov]

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (704a9fd) 57.37% compared to head (8db86d8) 57.43%.

❗ Current head 8db86d8 differs from pull request most recent head 0572e07. Consider uploading reports for the commit 0572e07 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11092      +/-   ##
==========================================
+ Coverage   57.37%   57.43%   +0.06%     
==========================================
  Files         129      129              
  Lines       11288    11285       -3     
==========================================
+ Hits         6476     6482       +6     
+ Misses       4180     4174       -6     
+ Partials      632      629       -3     

Files	Coverage Δ
pkg/compose/watch.go	35.61% <100.00%> (ø)
pkg/compose/create.go	58.11% <0.00%> (-0.68%)	⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[glours]

Hey @kimdcottrell
Compose policy enforce you to sign-up your commits, can you follow the steps described here to pass the DCO check please?

[kimdcottrell]

I started on a possibly iffy refactor of the duplicate code between the tests (the docker compose watch command and the cleanup functions), though I see this PR has already been approved. I'll stop working on that and assume no more work is required at this time, though I'm happy to come back to this if anything comes up. :)

[kimdcottrell]

Fixed some outstanding linter problems and remerged the base branch incase that was holding back the merge of this branch.