fix SIGTERM support to stop/kill stack #11127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
this fix signal management:
A dedicated goroutine is set to handle signal and trigger stop/kill commands (first signal will stop, the next one kills).
doneCh
is set to stop this goroutine when no sigterm signal is caught. It's not actually used as a channel, just as a way forselect
to react as channel is closed and stop the goroutineisTerminated
boolean let us know stack was terminated anddoneCh
doesn't need to be closed. It is set oncestop
succeed, so that it in the meantime we can capture subsequent SIGTERM and kill the stack.Note: this works well when ran by
~/.docker/cli-plugins/docker-compose up
orcom.docker.cli compose up
but when used with cloud integrations which forwards signals (😓) we receive duplicated SIGTERM signals and go runtime kills compose plugin after 3rd oneRelated issue
closes #11123
(not mandatory) A picture of a cute animal, if possible in relation to what you did