Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENGDOCS-1764: Trivial fixes #11149

Merged
merged 3 commits into from
Nov 2, 2023
Merged

ENGDOCS-1764: Trivial fixes #11149

merged 3 commits into from
Nov 2, 2023

Conversation

aevesdocker
Copy link
Contributor

What I did

Fixes capitalisation and punctuation issues. Aligns to style guide. Brings consistency.

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

Signed-off-by: aevesdocker <allie.sadler@docker.com>
Signed-off-by: aevesdocker <allie.sadler@docker.com>
Signed-off-by: aevesdocker <allie.sadler@docker.com>
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (328ca3f) 57.42% compared to head (4cd6195) 57.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11149   +/-   ##
=======================================
  Coverage   57.42%   57.42%           
=======================================
  Files         129      129           
  Lines       11299    11299           
=======================================
  Hits         6488     6488           
- Misses       4182     4183    +1     
+ Partials      629      628    -1     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aevesdocker
Copy link
Contributor Author

@glours @ndeloof When you get a spare second, can I get a quick review please?

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,7 +1,7 @@
# docker compose alpha dry-run

<!---MARKER_GEN_START-->
EXPERIMENTAL - Dry run command allow you to test a command without applying changes
Dry run command allows you to test a command without applying changes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not have this anymore 🤔
I'll do a PR to remove it

@glours glours merged commit 5661fd1 into docker:main Nov 2, 2023
26 checks passed
@aevesdocker
Copy link
Contributor Author

So speedy ⚡ thank you both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants