reject compose file using secrets|configs.driver or template_driver
#11185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
template_driver
branch
from
a438cfd
to
e0bae63
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11185 +/- ##
==========================================
- Coverage 56.90% 56.81% -0.09%
==========================================
Files 133 133
Lines 11370 11382 +12
==========================================
- Hits 6470 6467 -3
- Misses 4274 4286 +12
- Partials 626 629 +3
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
reject compose file using
secrets|configs.driver or template_driverthose are implemented by docker swarm configs/secrets engine-drivers, which have no equivalent component in Docker Compose, and we have no "extensibility" mechanism that would allow to run such a "driver" client-side (assuming we want to)
Related issue
see #11179