-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop the resource timer after last expected event #11357
Conversation
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11357 +/- ##
==========================================
- Coverage 56.74% 56.56% -0.18%
==========================================
Files 134 136 +2
Lines 11448 11541 +93
==========================================
+ Hits 6496 6528 +32
- Misses 4330 4387 +57
- Partials 622 626 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This seems to be broken again, after updating to Docker Desktop 4.29.0 |
What I did
Done
event status doesn't mean the resource reached the expected status, it typically is firstCreated
thenStarted
and eventuallyHealthy
. We need the TUI to be aware more events are expected and not stop the timer.Related issue
fixes #11326
(not mandatory) A picture of a cute animal, if possible in relation to what you did