Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): batch span exports to prevent blocking #11364

Merged
merged 1 commit into from
Jan 17, 2024

Commits on Jan 17, 2024

  1. fix(tracing): batch span exports to prevent blocking

    This was a bad configuration (my fault) that meant each span was
    exported synchronously, as it ended. That can cause weird behavior
    such as stuttering/blocking.
    
    There's really no reason to NOT use the batch processor, it's the
    recommended way to configure it. In the future, it might make sense
    to tune the intervals based on the fact that Compose is a CLI vs
    a long-running server app, but we handle flushing out on exit
    already, so it's not a huge deal.
    
    Signed-off-by: Milas Bowman <milas.bowman@docker.com>
    milas committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    62fadb6 View commit details
    Browse the repository at this point in the history