Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce config --variables to list compose model variables #11643

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Mar 21, 2024

What I did
introduce config --variables pseudo-command to list compose model variables

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@ndeloof ndeloof requested review from a team, glours, milas and jhrotko and removed request for a team March 21, 2024 09:35
@ndeloof ndeloof marked this pull request as draft March 21, 2024 09:35
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 55.56%. Comparing base (897d239) to head (c4a4c9c).

Files Patch % Lines
cmd/compose/config.go 28.57% 14 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11643      +/-   ##
==========================================
- Coverage   55.65%   55.56%   -0.09%     
==========================================
  Files         142      142              
  Lines       12241    12257      +16     
==========================================
- Hits         6813     6811       -2     
- Misses       4740     4756      +16     
- Partials      688      690       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndeloof ndeloof marked this pull request as ready for review March 21, 2024 15:05
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link
Contributor

@jhrotko jhrotko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit 25671ae into docker:main Mar 22, 2024
30 checks passed
matt9ucci added a commit to matt9ucci/DockerCompletion that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants