Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read COMPOSE_REMOVE_ORPHANS from .env #11714

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Apr 11, 2024

What I did

read COMPOSE_REMOVE_ORPHANS from project environment (after os.env and .env file has been loaded)
and assign --remove-orphans accordingly until user has explictely set the flag

Related issue
closes #11707

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof requested review from a team, glours, milas and jhrotko and removed request for a team April 11, 2024 07:23
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit b032999 into docker:main Apr 11, 2024
28 checks passed
@ndeloof ndeloof deleted the remove_orphans branch April 11, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] COMPOSE_REMOVE_ORPHANS only works as a shell variable, not in environment files
2 participants