chore(e2e): fix flaky cascade failure test #11739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milas
requested review from
ndeloof,
glours and
jhrotko
and removed request for
a team
🤔 |
🤔
|
This was racy with the sleep, so the Compose file has been tweaked to make it pass reliably. Now, there's 3 services: * `running` - sleeps forever * `exit` - exits _successfully_ immediately * depends on `running` started * `fail` - exits _with error_ immediately * depends on `exit` succeeding Now, the test can ensure that the containers are all run/ started in the expected order the assertions will be reliable. Before, it was possible for `fail` to run & exit before `exit`, for example. The `running` service also ensures there's always at least one other "running" container when we do an abort. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
glours
force-pushed
the
fix-e2e-cascade-flaky
branch
from
2b064e3
to
36bf0c4
Compare
glours
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This was racy with the sleep, so the Compose file has been tweaked to make it pass reliably.
Now, there's 3 services:
running- sleeps foreverexit- exits successfully immediatelyrunningstartedfail- exits with error immediatelyexitsucceedingNow, the test can ensure that the containers are all run/ started in the expected order the assertions will be reliable.
Before, it was possible for
failto run & exit beforeexit, for example. Therunningservice also ensures there's always at least one other "running" container when we do an abort.Related issue
n/a, just my failing CI jobs
(not mandatory) A picture of a cute animal, if possible in relation to what you did
