After container restart register printer consumer #12158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
When a container restarts, the value for its id is set to
false
fromcontainers
- meaning it is no longer attached (line 113). However, when the container starts and it is going to be attached, this container id exists incontainers
withfalse
value but we never set it back totrue
leading to the events being ignored in line 107.compose/pkg/compose/printer.go
Lines 100 to 116 in 34b1819
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did