Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(push): Fix unexpected EOF on alpha publish #12169

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

idsulik
Copy link
Collaborator

@idsulik idsulik commented Sep 27, 2024

What I did
Initialized Data slice for v1.DescriptorEmptyJSON to avoid unexpected EOF.
Here docker/buildx/util/imagetools/create.go:210 we pass bytes.NewReader(dt), but the dt is nil(internal/ocipush/push.go:182), because of that it can't copy data docker/buildx/util/imagetools/create.go:210 into the empty slice.

Related issue
#12167

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
@glours glours requested review from a team, ndeloof, glours and jhrotko and removed request for a team September 27, 2024 15:48
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit d9df7aa into docker:main Sep 30, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants