don't fail when trying to remove an orphan container during down command #9896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
requested review from
a team,
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
milas,
laurazard and
benja-M-1
and removed request for
a team
ndeloof
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Currently the down process stop when it tries to remove an orphan container that already have been removed.
Now we don't stop the process if such kind of containers is already gone.
Related issue
Reported internally by the extension team
(not mandatory) A picture of a cute animal, if possible in relation with what you did
