bump docker dependencies version #9925
Conversation
glours
force-pushed
the
update-docker-dependencies
branch
2 times, most recently
from
9d2c170
to
ad7909b
Compare
| github.com/docker/cli => github.com/docker/cli v20.10.3-0.20221013132413-1d6c6e2367e2+incompatible // 22.06 master branch | ||
| github.com/docker/docker => github.com/docker/docker v20.10.3-0.20221013203545-33ab36d6b304+incompatible // 22.06 branch | ||
| github.com/moby/buildkit => github.com/moby/buildkit v0.10.1-0.20220816171719-55ba9d14360a // same as buildx | ||
|
|
There was a problem hiding this comment.
oh! compose is already using 22.06 branch? Hm...
There was a problem hiding this comment.
yes, IIRC it was needed to use latest features offered by buildx (which is doing the same btw)
There was a problem hiding this comment.
There's also some code around the plugin init that's only in 22.06 IIRC
glours
force-pushed
the
update-docker-dependencies
branch
from
ad7909b
to
f85a51d
Compare
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
Codecov ReportBase: 75.86% // Head: 75.86% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## v2 #9925 +/- ##
=======================================
Coverage 75.86% 75.86%
=======================================
Files 2 2
Lines 232 232
=======================================
Hits 176 176
Misses 49 49
Partials 7 7 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
force-pushed
the
update-docker-dependencies
branch
from
f85a51d
to
18ce1f4
Compare
glours
requested review from
a team,
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
milas and
laurazard
and removed request for
a team
pkg/compose/build_buildkit.go
Outdated
| if f, err = driver.GetFactory(ng.Driver, true); f == nil || err != nil { | ||
| return nil, fmt.Errorf("failed to find buildx driver %q, error: %s", ng.Driver, err.Error()) |
There was a problem hiding this comment.
| if f, err = driver.GetFactory(ng.Driver, true); f == nil || err != nil { | |
| return nil, fmt.Errorf("failed to find buildx driver %q, error: %s", ng.Driver, err.Error()) | |
| if f, err = driver.GetFactory(ng.Driver, true); f == nil || err != nil { | |
| return nil, fmt.Errorf("failed to find buildx driver %q, error: %v", ng.Driver, err) |
Minor: I assume it's an invariant that f != nil if err == nil so this is probably excessively defensive
Co-authored-by: Nick Sieger <nicksieger@gmail.com> Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
Signed-off-by: Guillaume Lours 705411+glours@users.noreply.github.com
What I did
Bump version of Docker binaries
To limit the impact of this PR, I didn't change the
timeouttype in the API and just add a conversion function for now(not mandatory) A picture of a cute animal, if possible in relation with what you did
