Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] update to go1.21.11 #1023

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

thaJeztah
Copy link
Member

go1.21.11 (released 2024-06-04) includes security fixes to the archive/zip and net/netip packages, as well as bug fixes to the compiler, the go command, the runtime, and the os package. See the Go 1.21.11 milestone on our issue tracker for details;

From the security announcement;

We have just released Go versions 1.22.4 and 1.21.11, minor point releases. These minor releases include 2 security fixes following the security policy:

  • archive/zip: mishandling of corrupt central directory record

    The archive/zip package's handling of certain types of invalid zip files
    differed from the behavior of most zip implementations. This misalignment
    could be exploited to create an zip file with contents that vary depending
    on the implementation reading the file. The archive/zip package now rejects
    files containing these errors.

    Thanks to Yufan You for reporting this issue.

    This is CVE-2024-24789 and Go issue https://go.dev/issue/66869.

  • net/netip: unexpected behavior from Is methods for IPv4-mapped IPv6 addresses

    The various Is methods (IsPrivate, IsLoopback, etc) did not work as expected
    for IPv4-mapped IPv6 addresses, returning false for addresses which would
    return true in their traditional IPv4 forms.

    Thanks to Enze Wang of Alioth and Jianjun Chen of Zhongguancun Lab
    for reporting this issue.

    This is CVE-2024-24790 and Go issue https://go.dev/issue/67680.

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah self-assigned this Jun 4, 2024
@thaJeztah
Copy link
Member Author

CentOS 8 failures are expected, because it's EOL; I need to remove those from the build

@thaJeztah
Copy link
Member Author

go1.21.11 (released 2024-06-04) includes security fixes to the archive/zip
and net/netip packages, as well as bug fixes to the compiler, the go command,
the runtime, and the os package. See the Go 1.21.11 milestone on our issue
tracker for details;

- https://github.com/golang/go/issues?q=milestone%3AGo1.21.11+label%3ACherryPickApproved
- full diff: golang/go@go1.21.10...go1.21.11

From the security announcement;

We have just released Go versions 1.22.4 and 1.21.11, minor point releases.
These minor releases include 2 security fixes following the security policy:

- archive/zip: mishandling of corrupt central directory record

  The archive/zip package's handling of certain types of invalid zip files
  differed from the behavior of most zip implementations. This misalignment
  could be exploited to create an zip file with contents that vary depending
  on the implementation reading the file. The archive/zip package now rejects
  files containing these errors.

  Thanks to Yufan You for reporting this issue.

  This is CVE-2024-24789 and Go issue https://go.dev/issue/66869.

- net/netip: unexpected behavior from Is methods for IPv4-mapped IPv6 addresses

  The various Is methods (IsPrivate, IsLoopback, etc) did not work as expected
  for IPv4-mapped IPv6 addresses, returning false for addresses which would
  return true in their traditional IPv4 forms.

  Thanks to Enze Wang of Alioth and Jianjun Chen of Zhongguancun Lab
  for reporting this issue.

  This is CVE-2024-24790 and Go issue https://go.dev/issue/67680.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

And now getting throttled on Docker Hub 🙈


+ make IMAGE=debian:bullseye verify
docker run  --rm -i \
	-v "$(pwd):/v" \
	-e DEBIAN_FRONTEND=noninteractive \
	-e PACKAGE_REPO=prod \
	-w /v \
	debian:bullseye ./verify
Unable to find image 'debian:bullseye' locally
docker: Error response from daemon: Head "https://registry-1.docker.io/v2/library/debian/manifests/bullseye": toomanyrequests: Server capacity exceeded.
See 'docker run --help'.
make: *** [Makefile:95: verify] Error 125
script returned exit code 2
cleanWorkspace: Ensuring workspace is owned by ubuntu
— Print Message
<1s
chowning workspace
— Print Message
<1s
chowning workspace

@thaJeztah
Copy link
Member Author

Three time's a charm; all green now

@thaJeztah thaJeztah merged commit 46da75a into docker:master Jun 5, 2024
6 checks passed
@thaJeztah thaJeztah deleted the bump_go1.21.11 branch June 5, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants