[master] Fix CentOS 8 build #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enable PowerTools repo - Disable building btrfs, which is no longer supported on CentOS/RHEL Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
ping @arkodg @tiborvass @silvin-lubecki PTAL |
| @@ -79,7 +81,7 @@ export DOCKER_GITCOMMIT=%{_gitcommit} | |||
| mkdir -p /go/src/github.com/docker | |||
| ln -s /root/rpmbuild/BUILD/src/engine /go/src/github.com/docker/docker | |||
|
|
|||
| pushd engine | |||
| pushd /root/rpmbuild/BUILD/src/engine | |||
There was a problem hiding this comment.
nit: can't we use an RPM variable here, like $RPM_BUILD_ROOT ?
There was a problem hiding this comment.
I'll look at some cleaning up in a follow-up 👍
|
Just curious: How long do you expect it will take to start seeing the CentOS 8 RPMs in the docker-de repo (e.g. under https://download.docker.com/linux/centos/)? Will we need to wait until the next docker-ce release? Thanks! :) |
|
Yes, the plan is to add CentOS 8 for the next release, not in a 19.03.x patch release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #416
CentOS/RHEL