Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: add known issues to 20.10.15 release notes #14708

Merged
merged 1 commit into from
May 11, 2022
Merged

engine: add known issues to 20.10.15 release notes #14708

merged 1 commit into from
May 11, 2022

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented May 10, 2022 •
edited
Loading

@thaJeztah thaJeztah added the area/engine Issue affects Docker engine/daemon label May 10, 2022
@thaJeztah
Copy link
Member Author

@usha-mandya @dockertopia ptal

@netlify
Copy link

netlify bot commented May 10, 2022 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 6714825
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/627a5104fa1f0d0009670c15
😎 Deploy Preview https://deploy-preview-14708--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@thaJeztah thaJeztah mentioned this pull request May 10, 2022
Merged
1 task
dockertopia
dockertopia reviewed May 10, 2022
View reviewed changes
Copy link
Contributor

@dockertopia dockertopia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made a few minor suggestions.

engine/release-notes/index.md Outdated Show resolved Hide resolved
engine/release-notes/index.md Outdated Show resolved Hide resolved
engine/release-notes/index.md Outdated Show resolved Hide resolved
@thaJeztah thaJeztah force-pushed the engine_known_issues branch from 6dc0d92 to 35ef1df Compare May 10, 2022 11:08
@thaJeztah
Copy link
Member Author

Updated with your suggestions; changed the fix for the link to use fix for this issue (instead of the "has been merged"); PTAL if this looks good to you 🤗

Screenshot 2022-05-10 at 13 08 08

@usha-mandya
Copy link
Member

Thanks @thaJeztah. Looks good. There's a broken link to the Extensions doc which isnt part of this PR. I've re-run the failed jobs to see if that fixes any issues.

@thaJeztah
engine: add known issues to 20.10.15 release notes
6714825 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the engine_known_issues branch from 35ef1df to 6714825 Compare May 10, 2022 11:48
@thaJeztah
Copy link
Member Author

Bleh.. looks to be still failing; broken link may be in the external repository though;

- ./_site/desktop/extensions-sdk/extensions/labels/index.html
Ran on 1666 files!


  *  linking to internal hash #design-principles that does not exist (line 197)
     <a href="../../design/design-overview/#design-principles">CSS guidlines</a>

@thaJeztah
Copy link
Member Author

Fix for the above is in docker/extensions-sdk#160

usha-mandya
usha-mandya approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@usha-mandya usha-mandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usha-mandya usha-mandya merged commit 032837c into docker:master May 11, 2022
@thaJeztah thaJeztah deleted the engine_known_issues branch May 11, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dockertopia dockertopia dockertopia left review comments

@usha-mandya usha-mandya usha-mandya approved these changes

Assignees
No one assigned
Labels
area/engine Issue affects Docker engine/daemon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thaJeztah @usha-mandya @dockertopia