build: clarify that attestations expose build args #19281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
area/build
crazy-max
reviewed
Feb 1, 2024
dvdksn
force-pushed
the
docs-clarify-buildargs-leak-secrets
branch
2 times, most recently
from
6ff1d64
to
605abba
Compare
crazy-max
reviewed
Feb 1, 2024
People need to stop using build arguments for secrets. Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
docs-clarify-buildargs-leak-secrets
branch
from
605abba
to
ec5847e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
People need to stop using build arguments for secrets.
Signed-off-by: David Karlsson 35727626+dvdksn@users.noreply.github.com
Related issues (optional)
moby/buildkit#4608