Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: gha job summary, import build records #20057

Merged
merged 5 commits into from
Jun 7, 2024

Conversation

dvdksn
Copy link
Collaborator

@dvdksn dvdksn commented May 17, 2024

Description

This PR introduces:

  • A description of the job summary annotations for Docker's GitHub Actions
  • Instructions for importing build records into Docker Desktop

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added area/build Relates to Dockerfiles or docker build command area/desktop Issue affects a desktop edition of Docker. E.g docker for mac labels May 17, 2024
Copy link

netlify bot commented May 17, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 454f7d3
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/666331f335d7f3000865a9b9
😎 Deploy Preview https://deploy-preview-20057--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@colinhemmings colinhemmings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crazy-max
crazy-max previously approved these changes May 24, 2024
crazy-max
crazy-max previously approved these changes May 27, 2024
@dvdksn dvdksn added this to the 4.31 milestone May 27, 2024
@dvdksn dvdksn force-pushed the builds-view-import branch 2 times, most recently from f2cb1ed to c23ee12 Compare May 29, 2024 15:10
crazy-max
crazy-max previously approved these changes May 29, 2024
@dvdksn dvdksn force-pushed the builds-view-import branch from c23ee12 to 701ddd8 Compare June 4, 2024 08:56
@dvdksn dvdksn marked this pull request as ready for review June 4, 2024 08:56
@dvdksn dvdksn requested a review from aevesdocker as a code owner June 4, 2024 08:56
@dvdksn dvdksn added the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label Jun 4, 2024
@aevesdocker aevesdocker removed this from the 4.31 milestone Jun 6, 2024
dvdksn added 5 commits June 7, 2024 18:14
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@crazy-max crazy-max force-pushed the builds-view-import branch from 701ddd8 to 454f7d3 Compare June 7, 2024 16:14
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dvdksn dvdksn merged commit c967966 into docker:main Jun 7, 2024
11 checks passed
@dvdksn dvdksn deleted the builds-view-import branch June 7, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Relates to Dockerfiles or docker build command area/desktop Issue affects a desktop edition of Docker. E.g docker for mac status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants