update autotest descriptions #352
Conversation
| * `Off`: no additional tests. Test commits only to branches that are using Autobuild to build and push images. | ||
| * `Source Repository`: test commits to all branches of the source code repository, regardless of their Autobuild setting. | ||
| * `Source Repository & External Pull Requests`: tests commits to all branches of the source code repository, including any pull requests opened against it. | ||
| * `Off`: No additional test builds. Tests only run if they're configured as hooks in an automated build. |
There was a problem hiding this comment.
There is a default test hook that picks the docker-compose.test.yml.
There was a problem hiding this comment.
I'm sorry, can you clarify please?
If this is set to "off", what is it running?
There was a problem hiding this comment.
every autobuild runs build + test + push.
every autotest runs build + test.
Off deactivates autotests, but autobuilds still run the test phase.
There was a problem hiding this comment.
"autobuilds still run the test phase" <- That's what I'm saying. Should it be "as part of" rather than "as hooks in"?
There was a problem hiding this comment.
yes, that is what I mean, there is a default test behavior, even if test hooks are not defined.
| * `Source Repository`: test commits to all branches of the source code repository, regardless of their Autobuild setting. | ||
| * `Source Repository & External Pull Requests`: tests commits to all branches of the source code repository, including any pull requests opened against it. | ||
| * `Off`: No additional test builds. Tests only run if they're configured as hooks in an automated build. | ||
| * `Source repository`: Run a test build for any pull requests to branches that match a build rule, but only when the pull comes from the same source repository. |
There was a problem hiding this comment.
@pkennedyr We are renaming this to "Internal pull request" or something similar, right? Source repository does not make sense anymore
There was a problem hiding this comment.
"when the pull comes" does not make sense, it has to say "pull request".
There was a problem hiding this comment.
This is to match the current UI. I can patch the labels when we actually get them changed.
There was a problem hiding this comment.
Added "request"
| * `Source Repository & External Pull Requests`: tests commits to all branches of the source code repository, including any pull requests opened against it. | ||
| * `Off`: No additional test builds. Tests only run if they're configured as hooks in an automated build. | ||
| * `Source repository`: Run a test build for any pull requests to branches that match a build rule, but only when the pull comes from the same source repository. | ||
| * `Source repository & external pull requests`: Run a test build for any pull requests to branches that match a build rule, including when the pull originated in an external source repository. |
There was a problem hiding this comment.
Added "request"
Signed-off-by: LRubin <lrubin@docker.com>
Updating autotest descriptions
cc @pkennedyr and @pchico83
Signed-off-by: LRubin lrubin@docker.com