Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

absolute links to docs.docker.com are now relative links #418

Merged
merged 1 commit into from
Nov 2, 2016

Conversation

aduermael
Copy link
Contributor

Describe the proposed changes

Absolute links to docs.docker.com are now relative links.

I used that command:

$ ag -l "]\(https://docs.docker.com" . | xargs sed -i "" -e 's/\](https:\/\/docs.docker.com/\](/g'
$ ag -l "]\(http://docs.docker.com" . | xargs sed -i "" -e 's/\](http:\/\/docs.docker.com/\](/g'

Signed-off-by: Adrien Duermael adrien@duermael.com

Signed-off-by: Adrien Duermael <adrien@duermael.com>
@johndmulhausen
Copy link

Thanks a ton @aduermael ! This catches all the instances where markdown links were absolute! There are still HTML links (href="https://docs.docker.com/...), but this is a great start. Now staging and forking will still produce links that work!

@johndmulhausen johndmulhausen merged commit 27d00ce into docker:master Nov 2, 2016
@johndmulhausen johndmulhausen self-assigned this Nov 2, 2016
@aduermael
Copy link
Contributor Author

aduermael commented Nov 2, 2016

@johndmulhausen you're welcome! 🙂

Now staging and forking will still produce links that work!

Yes, that's what I was experiencing in my fork! 😝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants