Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigureTransport: make sure a clean DialContext is used for tcp #103

Merged
merged 2 commits into from
Oct 31, 2023
Merged

ConfigureTransport: make sure a clean DialContext is used for tcp #103

merged 2 commits into from
Oct 31, 2023

Commits on Oct 30, 2023

  1. Revert "sockets: defaultTimeout is unused on Windows (deadcode)" 

    This reverts commit fcf9eb7.

Signed-off-by: Albin Kerouanton <albinker@gmail.com>
    @akerouanton
    akerouanton committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    a83cc44 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. ConfigureTransport: make sure a clean DialContext is used for tcp 

    Since docker#61, there's no more DialContext defined in the default switch
case of ConfigureTransport. As a consequence, if ConfigureTransport was
already called with a npipe or unix proto (ie. Docker client does that
to initialize its HTTP client with the default DOCKER_HOST), the
DialContext function defined by these protocols will be used.

As the DialContext functions defined by unix and npipe protos totally
ignore DialContext's 2nd and 3rd argument (ie. network and addr) and
instead use the equivalent arguments passed to configureUnixTransport
and configureNpipeTransport when they were called, this results in
ConfigureTransport being totally ineffective.

Signed-off-by: Albin Kerouanton <albinker@gmail.com>
    @akerouanton
    akerouanton committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    ffe640f View commit details
    Browse the repository at this point in the history