add AllocateNetwork and FreeNetwork plugin apis #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dave-tucker
approved these changes
Oct 28, 2016
| NetworkID string | ||
| } | ||
|
|
||
| // FreeNetworkResponse is the response to a request for freeing a network. |
There was a problem hiding this comment.
I don't see this used anywhere... Is it necessary?
dave-tucker
reviewed
Oct 28, 2016
| @@ -242,6 +305,7 @@ func (h *Handler) initMux() { | |||
| if err != nil { | |||
| msg := err.Error() | |||
| sdk.EncodeResponse(w, NewErrorResponse(msg), msg) | |||
| return | |||
There was a problem hiding this comment.
This is a bug, but isn't directly related to your changes.
It might be helpful to note that it was changed in the commit message
Also fixed a minor error handling issue in createEndpointPath where the EncodeResponse is called twice incorrectly Signed-off-by: Madhu Venugopal <madhu@docker.com>
|
@dave-tucker thanks for the review. Updated. |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moby/moby#27287 brought in the support for swarm-mode network v1 plugins. These 2 APIs are introduced to support remote plugins in swarm-mode.
Also fixed a minor error handling issue in createEndpointPath where the EncodeResponse is called twice incorrectly
Signed-off-by: Madhu Venugopal madhu@docker.com