Skip to content
This repository has been archived by the owner on Sep 10, 2024. It is now read-only.

Refactor main #13

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Refactor main #13

merged 1 commit into from
Jan 24, 2023

Conversation

eunomie
Copy link
Member

@eunomie eunomie commented Jan 9, 2023

Move main.go to subfolder cmd/docker-index and update build steps.
The idea here is just to follow a quite common pattern where cmd/<something> produces the binary <something>. It's not mandatory at all, but might help to keep the code base organised.

✅ To be rebased once #11 is merged

Signed-off-by: Yves Brissaud <yves.brissaud@docker.com>
Copy link
Collaborator

@cdupuis cdupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I didn't know this has emerged as a standard now.

@eunomie
Copy link
Member Author

eunomie commented Jan 13, 2023

I didn't know this has emerged as a standard now.

Well... this is not really a standard. I think there's really different opinions on it. I prefer that way so it feels better organised from my views. And if at some point we need a different entry point then it's easy to add one. It's a bit of anticipation, but I don't really see downsides for now.
As an example, it's organised that way for gh CLI: https://github.com/cli/cli/tree/trunk/cmd

@cdupuis cdupuis merged commit e838579 into docker:main Jan 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants