This repository has been archived by the owner on Sep 26, 2021. It is now read-only.
Factoring Bats tests #1023
Closed
Factoring Bats tests #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker commands over the local socket was only tested for a few drivers. Test for all drivers. Also explicitely test for the return code. Signed-off-by: Vincent Bernat <Vincent.Bernat@exoscale.ch>
The comment seems to say this is a leftover of a copy/paste from the VirtualBox test. If not, the comment should be udpated. Signed-off-by: Vincent Bernat <Vincent.Bernat@exoscale.ch>
Use the same test as for other drivers by not trying to match a star. Signed-off-by: Vincent Bernat <Vincent.Bernat@exoscale.ch>
Use the same test as for other drivers by using the `-f` flag. Signed-off-by: Vincent Bernat <Vincent.Bernat@exoscale.ch>
Most driver integration tests are the same. We split those common tests into three files: machine creation testing (including ability to run containers and get info about them), machine stop/start cycle testing and machine destruction and cleanup. The only special cases are: - virtualbox driver comes with many more test cases - rackspace driver doesn't support start/stop commands Signed-off-by: Vincent Bernat <Vincent.Bernat@exoscale.ch>
|
@vincentbernat yeah i tried the same thing :) Thanks for the PR -- hopefully we'll get inclusion and can remove the boilerplate. Thanks! |
|
I think that we might be able to make this type of thing work if we wrapped the calls to bats with our own script. Discussion: sstephenson/bats#100 E.g., |
|
@nathanleclaire what does this mean for #1158? |
|
@ehazlett don't bother with this PR, I'll check the other PR when it is done. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I noticed that many driver Bats tests are just copy/paste of another one. I wanted to factor them to avoid divergence between tests. The first commits are just a normalization step for the last commit. Unfortunately, I understood how Bats work only at the end (when I wanted to test the changes): it uses a preprocessing phase to replace the
@testmarkers, so it is currently not possible to put common tests into another file. I have opened an issue about this: sstephenson/bats#99Until there is a solution, this PR is useless. I just push it here for reference, in case there is a workaround. Feel free to close it if you don't like unresolvable PR to hang around.