This repository has been archived by the owner on Sep 26, 2021. It is now read-only.
Default storage driver to "" and let provisioner choose default #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibuildthecloud
force-pushed
the
no-default-storage-driver
branch
from
d85f2a4
to
e8043e9
Compare
|
Looks like b2d supports all storage drivers. I will have to update that. |
The storage driver will be "" by default an the provisioner must choose their default provisioner. If the user chosen storage driver is not supported the provisioner should return an error. Signed-off-by: Darren Shepherd <darren@rancher.com>
ibuildthecloud
force-pushed
the
no-default-storage-driver
branch
from
e8043e9
to
43b5786
Compare
|
Updated to allow all drivers for b2d. |
|
LGTM |
|
cc @ehazlett |
|
LGTM |
ehazlett
added a commit
that referenced
this pull request
May 5, 2015
Default storage driver to "" and let provisioner choose default
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The storage driver will be "" by default an the provisioner must choose
their default provisioner. If the user chosen storage driver is not
supported the provisioner should return an error.
I changed boot2docker to throw an error if something besides aufs is chosen. I have no clue what boot2docker supports so that may be wrong.