This repository has been archived by the owner on Sep 26, 2021. It is now read-only.
Update "aufs" to "overlay2" in several places #4558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
|
Shouldn't this be made conditional on the ISO version, or something ? Not sure if there will any more releases, but the change makes sense... |
|
IMO it makes sense to use Alternatively we could try to remove a lot of this explicit graph driver choosing and let Docker itself DTRT, but with machine into maintenance-only mode, it seems like a bit much to make very drastic changes like that. |
|
I suppose you could always use older versions of Machine for older versions of Docker. |
afbjorklund
added a commit
to afbjorklund/minikube
that referenced
this pull request
Sep 8, 2018
The "aufs" storage driver has been deprecated, changed in Docker 17.09 for "overlay2" instead. See docker/machine#4558 This only affects the "boot2docker" provisioner, since it is already being used by "buildroot". Closes kubernetes#3078
dlorenc
pushed a commit
to kubernetes/minikube
that referenced
this pull request
Sep 10, 2018
The "aufs" storage driver has been deprecated, changed in Docker 17.09 for "overlay2" instead. See docker/machine#4558 This only affects the "boot2docker" provisioner, since it is already being used by "buildroot". Closes #3078
|
LGTM - thanks guys! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the default storage driver from
aufstooverlay2.Related issue(s)
graphdriver: promote overlay2 over aufs moby/moby#34430
overlay2now preferred overaufs(since 17.09.0; docker-archive/docker-ce@479e912)https://docs.docker.com/docker-for-windows/release-notes/#docker-community-edition-18060-ce-win70-2018-07-25
https://docs.docker.com/docker-for-mac/release-notes/#docker-community-edition-18060-ce-mac70-2018-07-25
Deprecate AUFS? boot2docker/boot2docker#1326
Given that
overlay2has been preferred overaufssince 17.09.0 and that the next major releases of Docker Desktop will no longer include AUFS support and that AUFS has consistently been a source of pain around updating the kernel in boot2docker, this makes a lot of sense.To be completely honest, I'm not sure I understand why Docker Machine is so explicit about choosing a graph driver instead of simply letting Docker autodetect/choose, but I'm sure there's context I'm missing (so this PR simply replaces
aufswithoverlay2in several places). 👍 ❤️