Skip to content
This repository has been archived by the owner on Sep 26, 2021. It is now read-only.

update usage for eval #866

Closed
wants to merge 1 commit into from
Closed

Conversation

ehazlett
Copy link
Contributor

@hairyhenderson mentioned issues with using quotes around eval for loading the environment. This updates the usage info after the create command to remove the quotes.

Signed-off-by: Evan Hazlett <ejhazlett@gmail.com>
@ehazlett ehazlett added this to the 0.2.0 milestone Mar 24, 2015
@nathanleclaire
Copy link
Contributor

Hang on- @tianon had quotes on it in #795 . Do we have a specific reproducible use case where we know this is an issue?

@tianon
Copy link
Contributor

tianon commented Mar 24, 2015

Quotes are definitely important for proper whitespace preservation, but I can't think of any current common issues with either way.

@nathanleclaire
Copy link
Contributor

OK - if we aren't aware of any issues with the status quo then I'm all for removing the quotes today. Should keep it in mind in the future though.

@nathanleclaire
Copy link
Contributor

I think there are some docs that will need to be updated with this too.

@ehazlett
Copy link
Contributor Author

@hairyhenderson can you provide some feedback for this?

#869 looks related too.

@tianon
Copy link
Contributor

tianon commented Mar 24, 2015

@nathanleclaire well hold up; if there aren't concrete problems removing them fixes, why remove them? They're definitely more "correct", AFAIK.

@ehazlett
Copy link
Contributor Author

Ok I'm going to close this one. I can't get any issue re-produced.

@hairyhenderson if you run into the issue again, can you file an issue with details on how to reproduce?

thanks all -- sorry for the noise.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants