-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the images
input to be empty, which outputs just the raw tags
#307
Conversation
Signed-off-by: Jason D'Amour <jasondamour98@gmail.com>
Signed-off-by: Jason D'Amour <jasondamour98@gmail.com>
Signed-off-by: Jason D'Amour <jasondamour98@gmail.com>
@crazy-max Can I get eyes on this before I resolve conflicts? |
Intended usage is for build tools which only take the tags as input, not the full image url. For example, this is working today:
|
jasondamour:empty-images |
// docker-bake.hcl target "build" { |
@tatality173 ??? What are you trying to say? |
@crazy-max thoughts? |
any updates on this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very sorry for the delay!
Changes LGTM but I think we need extra tests as well for this new use case. Can you rebase?
Updated from master. @crazy-max I don't really understand the testing framework, can you give some pointers |
Can you do a proper rebase instead of merge commit please?
In https://github.com/docker/metadata-action/blob/master/__tests__/meta.test.ts to test the case when no image is set. One in this suite metadata-action/__tests__/meta.test.ts Line 125 in 879dcbb
|
any news on this ? @crazy-max @jasondamour |
Addresses #212