Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{docsify-ignore-all} should better be replaced with <!-- {docsify-ignore-all} --> #441

Closed
hao-lee opened this issue Apr 2, 2018 · 2 comments · Fixed by #1318
Closed
Labels

Comments

@hao-lee
Copy link

hao-lee commented Apr 2, 2018

{docsify-ignore-all} will be rendered by GitHub or other Markdown engines, it looks very strange if someone reads docs on GitHub directly. So I suggest using <!-- {docsify-ignore-all} --> instead.

@stale
Copy link

stale bot commented Feb 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 4, 2020
@stale stale bot closed this as completed Feb 11, 2020
@anikethsaha anikethsaha reopened this May 14, 2020
@anikethsaha
Copy link
Member

I think this is better as it seems it will solve #767 as well (not sure , need to try it out).

Feel free to submit a PR

sy-records added a commit that referenced this issue Jul 30, 2020
…ts (#1318)

* breaking: convert {docsify-ignore} and {docsify-ignore-all} to HTML comments

Close #441

* chore: add ignore and ignore-all unit tests

Co-authored-by: 沈唁 <52o@qq52o.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants