Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: added codesandbox build preview for PR reviews #1193

Merged
merged 10 commits into from
Jun 8, 2020
Merged

ci: added codesandbox build preview for PR reviews #1193

merged 10 commits into from
Jun 8, 2020

Conversation

anikethsaha
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented May 23, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/irybw5mh0
✅ Preview: https://docsify-preview-git-codesandbox-ci.docsify-core.now.sh

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 23, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1982add:

Sandbox Source
strange-bird-pgh93 Configuration

@anikethsaha anikethsaha self-assigned this May 23, 2020
@anikethsaha anikethsaha reopened this May 23, 2020
@anikethsaha
Copy link
Member Author

anikethsaha commented May 23, 2020 •
edited
Loading

blocking

We need the cdn link for the published package so that we can use it with template.

If we somehow solve that, I will change the sandbox property in ./codesandbox/ci.yml to like this

{
  "sandbox":  ["./docs"],
}

So that we can test the changes with our preview of live docs.

This has to be manually done.
codesandbox ci will give us the build/publised version of the change like this.

There is a template already in the readme or use this to add a script tag with the published package's URL and test the changes in the sandbox.

@anikethsaha anikethsaha closed this Jun 7, 2020
@anikethsaha anikethsaha reopened this Jun 7, 2020
@anikethsaha anikethsaha mentioned this pull request Jun 7, 2020
Merged
19 tasks
@anikethsaha anikethsaha merged commit 817c079 into develop Jun 8, 2020
@sy-records sy-records deleted the codesandbox-ci branch June 8, 2020 07:51
trusktr added a commit that referenced this pull request Jun 13, 2020
@trusktr
Merge branch 'develop' into docsify-class
b15f450 
* develop:
  Update build/css.js
  use a port for the tests that doesn't collide with common local server ports
  Revert "Updated docs site dark and light mode with switch and redesigned search bar using docsify-darklight-theme" (#1207)
  ci: added codesandbox build preview for PR reviews (#1193)
  Update cover.md (#1134)
  chore: update auto format config
@snyk-bot snyk-bot mentioned this pull request Jun 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trusktr trusktr trusktr approved these changes

@sy-records sy-records sy-records approved these changes

@Koooooo-7 Koooooo-7 Awaiting requested review from Koooooo-7

Assignees

@anikethsaha anikethsaha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anikethsaha @trusktr @sy-records