Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: added carbon ad #1337

Merged
merged 2 commits into from
Aug 17, 2020
Merged

Docs: added carbon ad #1337

merged 2 commits into from
Aug 17, 2020

Conversation

anikethsaha
Copy link
Member

Added CarbonAds

@vercel
Copy link

vercel bot commented Aug 16, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/4wtw3y61l
✅ Preview: https://docsify-preview-git-carbonads.docsify-core.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 16, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 450189d:

Sandbox Source
docsify-template Configuration

@anikethsaha anikethsaha requested review from sy-records, jhildenbiddle, trusktr and Koooooo-7 and removed request for sy-records and jhildenbiddle August 16, 2020 08:26
sy-records
sy-records reviewed Aug 16, 2020
View reviewed changes
docs/index.html Outdated Show resolved Hide resolved
@anikethsaha anikethsaha added priority : high website related to the official docsify website: https://docsify.js.org labels Aug 16, 2020
Koooooo-7
Koooooo-7 reviewed Aug 16, 2020
View reviewed changes
Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sy-records I agree we can use that ads plugin or we can write the style instead of importing extra resource.

@anikethsaha
Copy link
Member Author

agreed let's use the plugin

@anikethsaha anikethsaha changed the base branch from develop to master August 17, 2020 14:34
@anikethsaha anikethsaha changed the base branch from master to develop August 17, 2020 14:34
@anikethsaha
Copy link
Member Author

We will need to release a version once it is merged in develop, I can directly submit a PR against master as there would be conflicts.

Koooooo-7
Koooooo-7 approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I m just working on it also, it seems a litte big.
LGTM.

@anikethsaha
Copy link
Member Author

I m just working on it also, it seems a litte big.

yeah if PR against master then the diff is quite big, We need to release it at the earliest

@anikethsaha anikethsaha merged commit cc071c5 into develop Aug 17, 2020
@sy-records sy-records deleted the carbonAds branch August 17, 2020 14:59
@snyk-bot snyk-bot mentioned this pull request Aug 21, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 12, 2020
Merged
@jhildenbiddle jhildenbiddle mentioned this pull request Mar 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sy-records sy-records sy-records approved these changes

@Koooooo-7 Koooooo-7 Koooooo-7 approved these changes

@trusktr trusktr Awaiting requested review from trusktr

@jhildenbiddle jhildenbiddle Awaiting requested review from jhildenbiddle

Assignees
No one assigned
Labels
priority : high website related to the official docsify website: https://docsify.js.org
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anikethsaha @Koooooo-7 @sy-records