Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ssr TypeError: Cannot read property 'indexOf' of undefined #1627

Closed
wants to merge 3 commits into from

Conversation

funcode-life
Copy link

@funcode-life funcode-life commented Aug 19, 2021

See this problem in issue:
#704

Summary

What kind of change does this PR introduce?

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercel bot commented Aug 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/6x5nWFyDtaarQUUPrdaQFT1BV7u3
✅ Preview: https://docsify-preview-git-fork-dysdf-fix-ssr-error-docsify-core.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 19, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6428c84:

Sandbox Source
docsify-template Configuration

@Koooooo-7 Koooooo-7 requested a review from trusktr August 19, 2021 07:40
@xiao99xiao
Copy link

@trusktr @Koooooo-7 May I ask what is the status of this PR? Since it resolves a major issue that blocks the usage of SSR, I really hope it could be merged soon.

@Koooooo-7
Copy link
Member

@xiao99xiao Cause the SSR refactor has not set in place yet, it may be late to merge.

@trusktr do u think we could merge it as a patch for current SSR solution?

cc @docsifyjs/reviewers

@trusktr
Copy link
Member

trusktr commented Sep 9, 2021

Yeah, this is already fixed in my work. SSR is working, but not all things work yet. Namely we still need some special handling for plugins. Another issue I have is I haven't installed a VM for testing, the tests don't pass in my native OS. I will circle back again soon, i haven't forgotten!

@vercel
Copy link

vercel bot commented Aug 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docsify-preview ✅ Ready (Inspect) Visit Preview Aug 23, 2022 at 7:27AM (UTC)

@funcode-life
Copy link
Author

related pr

@sy-records
Copy link
Member

see #2105

@sy-records sy-records closed this Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants