Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cannot read property 'tagName' of null #1655

Merged
merged 2 commits into from
Oct 22, 2021
Merged

fix: Cannot read property 'tagName' of null #1655

merged 2 commits into from
Oct 22, 2021

Conversation

woshiguabi
Copy link
Contributor

@woshiguabi woshiguabi commented Oct 21, 2021

Summary

Have a look at this issue #1154 .
https://codesandbox.io/s/loving-matsumoto-hp985?file=/index.html
Open devtools and click the blank space of svg(not path) will reproduce this issue.

parentNode may be null.
https://github.com/docsifyjs/docsify/blob/develop/src/core/router/history/html5.js#L25-L27

However, hash router has been fixed in #1308 😜.
https://github.com/docsifyjs/docsify/blob/develop/src/core/router/history/hash.js#L47-L49

What kind of change does this PR introduce?

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

#1154

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercel bot commented Oct 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/6SWPME9qPjSDoSFCssTxdEYLazkZ
✅ Preview: https://docsify-preview-git-fork-woshiguabi-patch-1-docsify-core.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 21, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ae4a2f6:

Sandbox Source
docsify-template Configuration
wispy-cdn-23i3u PR

Copy link
Member

@sy-records sy-records left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sy-records sy-records requested a review from a team October 22, 2021 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants