Backporting ignoring phpcsSuppress annotation to 1.8. #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phpeek
force-pushed
the
ignore-phpcs-supress
branch
from
678d832
to
3337577
Compare
SenseException
approved these changes
Sep 23, 2019
alcaeus
approved these changes
Sep 24, 2019
|
Thanks @phpeek! Don't worry about a separate PR with tests to Do you plan to backport the other PRs I mentioned as not being part of 1.x? |
|
@alcaeus I apologize. Haven't checked all Your mentioned PRs. I assumed they were all about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised in #277, i'm backporting ignoring
@phpcsSuppressto1.8.Just to be 100% sure, I've added test-case for this. Not sure if similar test-case exists in
master. I'll double-check and - if not - will issue PR with test-case formastertomorrow, unless it's not needed.