Merge release 1.10.4 into master #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace "blacklist" terminology with "ignore"
update annotation IDE annotation with current links
The version of webmozart/assert we use conflicts with lower versions.
Not prefixing it with a backslash does not work as expected.
phpbench recently dropped compatibilty with PHP 7.1 When this job was introduced, 7.1 was the latest version of PHP we supported, so it makes sense to bump to 7.4 now. See https://github.com/phpbench/phpbench/releases/tag/0.17.0
Make type in phpdoc resolvable
It makes the code more readable and IDE less confused.
This should help getting the PHP 8 build closer to a successful one. Fixes #340
That is a version where we can installed newer versions of PHPUnit, and use methods that may not exist otherwise.
DocParser: Improve private typehints
Upgrade phpunit
That is the only version that is compatible with PHP 8. Lowering the minimum-stability on the nightly build is necessary until 9.3.0 is published.
Allow using PHPUnit 9.3
It has been deprecated as of PHPUnit 9 Note that we still rely on the call order here, I am not the original author of this test but the order looks like it is pretty important for this test, or maybe at least for understanding it. Also note that we no longer check that save() is called after all calls to fetch().
The T_STRING and T_NS_SEPARATOR tokens are used differently in use statements. Treating them the same makes the code harder to follow and harder to adapt for PHP 8.
Co-authored-by: Soner Sayakci <s.sayakci@shopware.com>
Remove calls to TestCase::at()
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
Add support for the new PHP 8 tokens for use statements
greg0ire
approved these changes
Aug 11, 2020
greg0ire
deleted the
1.10.x-merge-up-into-master_5f3295487aede7.72510405
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 1.10.4
1.10.4
Total issues resolved: 0
Total pull requests resolved: 8
Total contributors: 5
347: Add support for the new PHP 8 tokens for use statements thanks to @stof
345: Remove calls to TestCase::at() thanks to @greg0ire
343: Allow using PHPUnit 9.3 thanks to @greg0ire
Improvement
bug
Documentation
Documentation,Improvement