Do not cast null to array #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
previously approved these changes
Dec 12, 2022
The possibility that null could be returned was overlooked in 2286f7b .
greg0ire
force-pushed
the
dont-cast-null
branch
from
8a5df0d
to
fd04499
Compare
greg0ire
commented
Dec 12, 2022
| @@ -22,5 +22,3 @@ parameters: | |||
|
|
|||
| # That tag is empty on purpose | |||
| - '#PHPDoc tag @var has invalid value \(\)\: Unexpected token "\*/", expected type at offset 9#' | |||
| # Backwards-compatibility | |||
| - '#^Return type.*of method.*DocLexer::peek.*should be compatible.*$#' | |||
There was a problem hiding this comment.
Actually, the parent type returns array, so it should not be happy with this 🤔
There was a problem hiding this comment.
Ah Phpstan is only at level 3 🤔
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The possibility that null could be returned was overlooked in 2286f7b .
Fixes #462